fix: use string manipulation instead of regex to inject esbuild helpers#14094
Merged
sapphi-red merged 4 commits intovitejs:mainfrom Aug 25, 2023
Merged
fix: use string manipulation instead of regex to inject esbuild helpers#14094sapphi-red merged 4 commits intovitejs:mainfrom
sapphi-red merged 4 commits intovitejs:mainfrom
Conversation
|
|
Contributor
Author
|
@patak-dev @sapphi-red @bluwy would you please review this? We're currently blocked on webpack-to-vite switch due to umd build hanging caused by regex. Let me know if I got anything wrong and I'll fix. Thank you! |
bluwy
previously approved these changes
Aug 18, 2023
Member
bluwy
left a comment
There was a problem hiding this comment.
Makes sense to me and looks more performant too. Thanks for the PR!
Will wait for another eye on this before merging.
sapphi-red
reviewed
Aug 19, 2023
sapphi-red
reviewed
Aug 25, 2023
bluwy
approved these changes
Aug 25, 2023
sapphi-red
approved these changes
Aug 25, 2023
|
evanw/esbuild#3322 has been fixed. |
9 tasks
bluwy
pushed a commit
that referenced
this pull request
Oct 3, 2023
bluwy
pushed a commit
that referenced
this pull request
Oct 3, 2023
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #14065 lib mode hanging for umd build, by using string manipulation instead of regex
Additional context
The original fix #7948 used regex for string replacement to avoid global esbuild helpers.
It has since caused multiple performance issues #8738 #8099 #10900 #14065, and received numerous attempts #8110 #8741 #10905 at fixing it, but there're still unhandled cases:
I think this shows that regex isn't the right solution in this scenario. It's easier to manipulate the string directly, at the cost of a few extra lines.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).